Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force CPU-hang on errors in FW #112

Closed
secworks opened this issue Apr 3, 2023 · 3 comments · Fixed by #168
Closed

Force CPU-hang on errors in FW #112

secworks opened this issue Apr 3, 2023 · 3 comments · Fixed by #168
Assignees
Labels
enhancement New feature or request

Comments

@secworks
Copy link
Contributor

secworks commented Apr 3, 2023

I suggest that errors caught by the FW should be handled by forcing the CPU to hang, not by jumping to an error loop that does the LED blinking. A SW loop could possibly be forced to jump somewhere. By triggering an illegal instruction, the CPU will hang and stop executing. The external effect will be the same - blinking red.

@dehanj dehanj added the enhancement New feature or request label Sep 11, 2023
@dehanj
Copy link
Member

dehanj commented Sep 11, 2023

Use assert_fail() from tkey-libs.
This will harmonize code used and lower the amount of code to maintain.

@mchack-work
Copy link
Member

See #129

@dehanj dehanj self-assigned this Mar 14, 2024
@dehanj dehanj linked a pull request Mar 14, 2024 that will close this issue
@dehanj
Copy link
Member

dehanj commented Mar 14, 2024

Closes with #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants