FW: Force the CPU to hang on errors #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanj
force-pushed
the
112-force-cpu-hang
branch
from
c3ecd38
to
6ce40d1
Compare
dehanj
force-pushed
the
112-force-cpu-hang
branch
from
6ce40d1
to
9d36acd
Compare
Since we now use assert() and feed the CPU an unimplemented instruction we have no need for this.
mchack-work
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
I removed the unused function forever_redflash(). Doesn't change the digest since it was unused anyway.
Tested on real hardware by running a signer, signing and verifying.
Tested on real hw by sending garbage that tickled the assert.
Everything looks good. Approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a software loop on errors, we halt the CPU.
For the users it is no difference, the LED will be flashed RED by hw instead.