fix applied upper bound #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gengliqi @Connor1996 PTAL |
Signed-off-by: glorv <[email protected]>
gengliqi
approved these changes
Apr 1, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#537 introduce the new config
max_applied_unpersisted_log_limitthat changes applied upper bound tomin(committed, persisted + max_applied_unpersisted_log_limit), but sincemax_applied_unpersisted_log_limitcan be changed dynamically, we can't directly use it as the upper bound ofapplied_to, so this PR loose the upper bound tocommitted.