Skip to content

Commit

Permalink
remove note
Browse files Browse the repository at this point in the history
Signed-off-by: Little-Wallace <[email protected]>
  • Loading branch information
Little-Wallace committed Sep 25, 2020
1 parent cc28875 commit 6eb627e
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/engine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,6 @@ where
}
}

// Write a batch needs 3 steps:
// 1. find all involved raft groups and then lock their memtables;
// 2. append the log batch to pipe log;
// 3. update all involved memtables.
// The lock logic is a little complex. However it's necessary because
// 1. "Inactive log rewrite" needs to keep logs on pipe log order;
// 2. Users can call `append` on one raft group concurrently.
// Maybe we can improve the implement of "inactive log rewrite" and
// forbid concurrent `append` to remove locks here.
async fn write_impl(&self, log_batch: &mut LogBatch<E, W>, sync: bool) -> Result<usize> {
let mut entries_size = 0;
if let Some(content) = log_batch.encode_to_bytes(&mut entries_size) {
Expand Down

0 comments on commit 6eb627e

Please sign in to comment.