Bump the min PHP version to PHP 7.4 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to work on adding phpstan in this project, I figured out that it would be a lot simpler to setup if our min PHP version was compatible with the min version required by phpstan (so that we can use a normal
require-devto install it).As we have an unreleased version bump already (from PHP 5.5 to PHP 7.2.5), I'm updating it to bump to 7.4 instead (which is still outside the list of maintained PHP versions, but still represents 5% of installs in the packagist stats so I'm keeping it as it does not annoy me to keep support for it).