-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html_entity_decode() clears the DOM entities #145
Conversation
this is broken, because some of them cannot be decoded (for instance, decoding |
097ebec
to
653c8ca
Compare
@techi602 decoding |
@stof I dont think so - so i added testSpecialCharactersExplicit() |
public function testSpecialCharacters() | ||
{ | ||
$text | ||
= '1 < 2'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line wrapping is useless. You should keep things on the same line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well the reason is to be human readable so you can see that two lines are the same
Or would you prefer to have only one variable for $actual and $expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find this code more readable actually. It just looks weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how about now? 😄
Fixed in #154 |
Although biggest issue with foreign encoding was fixed in #131 the problem is that some e-mail clients such as thunderbird have issues with displaying entities as characters. Therefore is safer to present them UTF-8 characters instead of entities.