Detect XML header CssToInlineStyles::createDomDocumentFromHtml() #139
Conversation
| @@ -101,7 +101,7 @@ public function getInlineStyles(\DOMElement $element) | |||
| protected function createDomDocumentFromHtml($html) | |||
| { | |||
| $html = trim($html); | |||
| if (strstr('<?xml', $html) !== 0) { | |||
| if (strpos('<?xml', $html) !== 0) { | |||
There was a problem hiding this comment.
There is no test to cover the scenario with an XML opening tag.
There was a problem hiding this comment.
unfortunately it is protected method so adding meaningful test is difficult
Initial test was added in previous PR linked in this PR
There was a problem hiding this comment.
@techi602 you can write tests using the public API which calls this one, i.e. trying to process some HTML containing the XML opening tag
There was a problem hiding this comment.
Well this test is covered in #131 testHtmlEncoding()
There was a problem hiding this comment.
Funny thing is that this bug has no effect since adding xml header multiple times is ignored by DomDocument therefore is difficult to write failing test in this PR 🙈
|
Fixed in #154 |
Solve issue with adding xml header twice into DomDocument in #131
(Luckily DomDocument will handle two xml headers anyway)