Add support for UTF-8 characters #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… encoding it to UTF-8 after loading, the character set is preserved. Characters are not escaped, since it's not the job of this class.
jeroenvdheuvel
force-pushed
the
utf8_encoding
branch
from
5bf039e to
1248637
Compare
|
Closed, issue is fixed with #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support UTF-8 characters by adding an XML opening tag containing the encoding. Got the idea from: http://php.net/manual/en/domdocument.loadhtml.php#95251
By encoding it to UTF-8 after html is loaded, the encoding is preserved. Because the encoding is preserved, the UTF-8 characters are not escaped to htmlentities. So
€stays€.I prefer this, because I think it's not the responsibility of this class to alter the inner content of html nodes.