Use pwm esc unconditionally #829
Conversation
haitomatic
force-pushed
the
use_pwm_esc_unconditionally
branch
4 times, most recently
from
f0d7ffd to
0a46375
Compare
haitomatic
force-pushed
the
use_pwm_esc_unconditionally
branch
from
0a46375 to
b85fec8
Compare
|
Since actuator_output max, min and disarmed default values have been changed for HITL (similar to real drone), the flight behavior of supported HITL models might be different, previous default HITL actuator_output max, min and disarmed values have been added to HITL configs in |
haitomatic
force-pushed
the
use_pwm_esc_unconditionally
branch
2 times, most recently
from
da3a5e7 to
7f913a6
Compare
src/drivers/pwm_esc/pwm_esc.cpp
Outdated
| @@ -31,9 +31,9 @@ | |||
| * | |||
| ****************************************************************************/ | |||
|
|
|||
| /** | |||
| /**const uint32_t reversible_outputs = _mixing_output.reversibleOutputs(); | |||
There was a problem hiding this comment.
ah, that's dropped there by mistake. I will clean up
| @@ -31,19 +31,13 @@ | |||
| # | |||
| ############################################################################ | |||
|
|
|||
| if(${PX4_BOARD_VENDOR}_${PX4_BOARD_MODEL} STREQUAL "px4_sitl") | |||
There was a problem hiding this comment.
do we actually need to make any modifications to pwm_out_sim, if we are not using the component?
There was a problem hiding this comment.
hmm, so maybe i should leave it untouched ? so that the module is still in sync with upstream.
haitomatic
force-pushed
the
use_pwm_esc_unconditionally
branch
4 times, most recently
from
0a96618 to
61452ac
Compare
haitomatic
force-pushed
the
use_pwm_esc_unconditionally
branch
2 times, most recently
from
4838f0c to
b99b7cd
Compare
haitomatic
force-pushed
the
use_pwm_esc_unconditionally
branch
from
b99b7cd to
9f65415
Compare
pwm_out_simpwm_escfor HITL modepwm_escto be used at the same with UAVCAN ESCTested on saluki v3 HIITL mode with mc, fw and vtol