Multi-arch build #42
Merged
Multi-arch build #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jari-hodju
commented
Sep 21, 2023
jari-hodju
commented
- re-branched from main due to long list of merge conflicts
- additions and changes from feat-multiarch
- sdk and base image upgrades
- github actions upgrades
- for general info on multi-arch builds, see https://github.com/tiiuae/fog-ros-baseimage/blob/main/docs/Multiarchitecture_builds.md
- re-branched from main due to long list of merge conflicts - additions and changes from feat-multiarch - sdk and base image upgrades - github actions upgrades - for general info on multi-arch builds, see https://github.com/tiiuae/fog-ros-baseimage/blob/main/docs/Multiarchitecture_builds.md
mehmetkillioglu
approved these changes
Sep 21, 2023
joonas-fi
reviewed
Oct 23, 2023
|
|
||
| FROM ghcr.io/tiiuae/fog-ros-baseimage:v2.1.0 | ||
|
|
||
| HEALTHCHECK --interval=5s \ |
There was a problem hiding this comment.
Health checks were removed with this commit.
I noticed from Marita's shared logs:
🟨 $hypervisor.mocap-pose | no health check specified
http://100.117.239.56/logs/2023-10-23_10_46-back-12m0s-ghaf/health.txt
I guess this is an accidental regression and not on purpose.
jari-hodju
added a commit
that referenced
this pull request
Oct 23, 2023
* Multi-arch build - re-branched from main due to long list of merge conflicts - additions and changes from feat-multiarch - sdk and base image upgrades - github actions upgrades - for general info on multi-arch builds, see https://github.com/tiiuae/fog-ros-baseimage/blob/main/docs/Multiarchitecture_builds.md * Update baseimage version to v3.0.0 release * Upgrade baseimage version to v3.0.1 --------- Co-authored-by: Mehmet Killioglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.