Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SL translations #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve SL translations #363

wants to merge 1 commit into from

Conversation

urbanrotnik
Copy link

Add missing SL translations and improve existing translations.

@urbanrotnik urbanrotnik force-pushed the improve-sl-translations branch 3 times, most recently from 3c2074f to b5c152e Compare October 30, 2024 19:51
@JasonBarnabe
Copy link
Collaborator

JasonBarnabe commented Oct 30, 2024 •
edited
Loading

Thanks for this. Two things:

  1. According to this, Slovenian's pluralization rules are that there should be one, two, few, and other keys. You can see an example for the not_saved key. Can you add the missing plural forms for the translations you're adding - user and minimum_password_length?
  2. This project is in the middle of getting moved to https://github.com/devise-i18n/devise-i18n. You can create a PR there instead, or you can fix the above issue and I'll port it over, or you can make your changes with a UI at https://app.transifex.com/devise-i18n/devise-i18n-1/dashboard/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urbanrotnik @JasonBarnabe