Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load system certs for manager, and use correct location #2367

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ozdanborne
Copy link
Member

Description

Recent changes made to operator remove the root ca bundle from enterprise components docker images and instead volume mount them into pods at runtime using tigera-ca-bundle. In cases where root certs are needed they're included, but if they're not needed, they're left out.

In Enterprise with Dex, the oidc provider is internal and thus public ca bundles aren't needed. However, when using oidc.type=tigera, voltron directly connects to the external OIDC provider. As such, this PR has been updated to include root ca bundles in Manager when Tigera is used as the oidc connector.

Note: It is possible that a customer uses Tigera as an OIDC connector to a CA that is running inside the cluster, in which case public ca bundle is not needed. But this code ignores that corner case since there's no known customer use cases where that is true, and even if it is, loading the public bundle does no harm.

Additionally, this PR fixes a bug in Manager where the ca bundle directory + filename combination is not correct. This combination is dictated by the OS. See combinations here. Since we're using a ca bundle file of ca-bundle.crt, the only place it can be read from with that name is /etc/pki/tls/certs

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@mgleung mgleung modified the milestones: v1.29.0, v1.30.0 Jan 13, 2023
@danudey danudey modified the milestones: v1.30.0, v1.30.1 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants