Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port rosbag2_to_annotated_t4_tlr #62

Merged
merged 18 commits into from
Dec 18, 2023

Conversation

kminoda
Copy link
Collaborator

@kminoda kminoda commented Dec 14, 2023

Description

Port TLR related converters from AWMLDataset

See also: https://github.com/tier4/AWMLdataset/pull/199

How to review

  • Please check if I am using correct messages for TrafficLightArray and TrafficLightRoiArray
  • Please check if Rosbag2 -> Annotated T4 TLR dataset succeeds
  • Please check if Rosbag2 w/ GT -> Annotated T4 TLR dataset succeeds
    • Confirmed on my end that the dataset is apparently created without error (Although I commented out "pointcloud" in rosbag2_converter.py for this test)
  • Please check if Annotated T4 TLR dataset -> Deepen succeeds
    • Confirmed on my end that the dataset is apparently created without error

How to test

test data

  • Rosbag2 -> Annotated T4 TLR dataset
    • Any data is fine
  • Annotated T4 TLR dataset -> Deepen
    • Any data is fine
  • Rosbag2 w/ GT -> Annotated T4 TLR dataset
    • Sample data provided in this repository

test command

python3 -m perception_dataset.convert --config config/rosbag2_to_t4/convert_rosbag2_to_annotated_t4_tlr.yaml
python3 -m perception_dataset.convert --config config/rosbag2_to_t4/convert_rosbag2_with_gt_to_annotated_t4_tlr.yaml
python3 -m perception_dataset.convert --config config/convert_annotated_t4_tlr_to_deepen_sample.yaml

Reference

None

Notes for reviewer

None

@kminoda kminoda marked this pull request as ready for review December 14, 2023 05:22
@kminoda kminoda requested a review from miursh December 14, 2023 05:23
@miursh
Copy link
Collaborator

miursh commented Dec 18, 2023

@kminoda
Thank you for porting the TLR related converter. I made a few minor changes.

@miursh miursh merged commit 1fb99d1 into main Dec 18, 2023
6 checks passed
@miursh miursh deleted the feat/port/rosbag2_to_annotated_t4_tlr branch December 18, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants