Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add warning message for https://github.com/tier4/AWMLdataset/issues/125 #49

Closed
wants to merge 3 commits into from

Conversation

kminoda
Copy link
Collaborator

@kminoda kminoda commented Nov 21, 2023

Description

Add warning message for https://github.com/tier4/AWMLdataset/issues/125

How to review

Not applicable

How to test

Not applicable

Sample output with my local rosbag

frame472, stamp = 1698032458.2372313, diff cam - lidar = 0.061 sec                                                                                                                                                 
frame472, image stamp: 1698032458.2372313                                                                                                                                                                          
!!!WARNING!!! Please consider specifying `num_load_frames` with smaller size than 473 in config file. See also: https://github.com/tier4/AWMLdataset/issues/125                                                    
Traceback (most recent call last):                                                                                                                                                                                 
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main                                                                                                                                            
    return _run_code(code, main_globals, None,                                                           
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code                                             
    exec(code, run_globals)                                                                                                                                                                                        
  File "/home/minoda/ghq/github.com/tier4/AWMLDataset/awml_dataset/convert.py", line 199, in <module>                                                                                                              
    main()                                                                                                                                                                                                         
  File "/home/minoda/ghq/github.com/tier4/AWMLDataset/awml_dataset/convert.py", line 115, in main                                                                                                                  
    converter.convert()                                                                                                                                                                                            
  File "/home/minoda/.cache/pypoetry/virtualenvs/awml-dataset-7loCTFrj-py3.10/lib/python3.10/site-packages/perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py", line 96, in convert               
    bag_converter.convert()                                                                                                                                                                                        
  File "/home/minoda/.cache/pypoetry/virtualenvs/awml-dataset-7loCTFrj-py3.10/lib/python3.10/site-packages/perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py", line 233, in convert              
    self._convert()                                                                                                                                                                                                
  File "/home/minoda/.cache/pypoetry/virtualenvs/awml-dataset-7loCTFrj-py3.10/lib/python3.10/site-packages/perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py", line 297, in _convert             
    self._convert_sensor_data(sensor_channel_to_sample_data_token_list, scene_token)                                                                                                                               
  File "/home/minoda/.cache/pypoetry/virtualenvs/awml-dataset-7loCTFrj-py3.10/lib/python3.10/site-packages/perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py", line 356, in _convert_sensor_data 
    sensor_channel_to_sample_data_token_list[sensor_channel] = self._convert_image(                                                                                                                                
  File "/home/minoda/.cache/pypoetry/virtualenvs/awml-dataset-7loCTFrj-py3.10/lib/python3.10/site-packages/perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py", line 604, in _convert_image       
    sample_record: SampleRecord = sample_records[frame_index]                                                                                                                                                      
IndexError: list index out of range   

Reference

https://github.com/tier4/AWMLdataset/issues/125

Notes for reviewer

Not applicable

@kminoda kminoda marked this pull request as ready for review November 21, 2023 09:00
@kminoda kminoda requested a review from Shin-kyoto November 21, 2023 09:00
Signed-off-by: kminoda <[email protected]>
@kminoda kminoda marked this pull request as draft November 22, 2023 00:53
@Shin-kyoto
Copy link
Contributor

Shin-kyoto commented Dec 10, 2023

  • Thanks to this PR, I can understand which parameter I should change when I get the problem with rosbag -> non annotated dataset conversion. This PR is super helpful.
  • However, there is an issue that requires changing num_load_frames for each rosbag.
    • e.g. For one rosbag, num_load_frames must be 597 or less, and for another rosbag, it must be 594 or less.
  • The converter in AWMLdataset is designed to process all rosbags in a directory at once, but due to this issue, there is a need to convert each rosbag one by one.

@kminoda
Copy link
Collaborator Author

kminoda commented Dec 10, 2023

True, thanks!
(Anyway this is a draft PR so will update when I make this open)

@kminoda kminoda closed this Dec 28, 2023
@kminoda kminoda deleted the chore/issue_125/add_warning_message branch August 14, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants