Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deepen_to_t4): handling non keyframe in sample #38

Merged
merged 16 commits into from
Dec 5, 2023

Conversation

miursh
Copy link
Collaborator

@miursh miursh commented Oct 24, 2023

Description

  • Add KeyFrameConsistencyResolver class
  • Each function within the class is used to resolve keyframe consistency.
    • This includes tasks such as removing non-keyframe samples, changing sample tokens to the next closest keyframe, and organizing data and annotations.

How to review

try Deepen_to_t4 conversion and confirm that

  • Non-keyframe data is not included in the sample list.
  • The code adheres to the specification, which states, "A sample is an annotated keyframe at 2 Hz. The timestamp of a sample is the same as that of a LiDAR sample data."
  • The generated T4 dataset has passed validation

How to test

test data

test command

Reference

Notes for reviewer

@miursh miursh requested a review from Guolong-Zhang October 24, 2023 07:00
Copy link

@Guolong-Zhang Guolong-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with DBv3.0 shiojiri data. LGTM.

@Guolong-Zhang Guolong-Zhang self-requested a review October 24, 2023 08:39
@miursh miursh changed the title fix(deeoen_to_t4): handling non keyframe sample fix(deepen_to_t4): handling non keyframe in sample Oct 24, 2023
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
@miursh miursh force-pushed the fix/non_keyframe_sample_token branch from 977f02f to c6ffc7a Compare November 21, 2023 19:05
@miursh miursh force-pushed the fix/non_keyframe_sample_token branch from 084ea1e to 85e7ce1 Compare November 23, 2023 05:41
@miursh miursh force-pushed the fix/non_keyframe_sample_token branch from 91fca50 to 0457627 Compare December 5, 2023 16:36
@miursh miursh merged commit af2224f into main Dec 5, 2023
6 checks passed
@miursh miursh deleted the fix/non_keyframe_sample_token branch December 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants