-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deepen_to_t4): handling non keyframe in sample #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guolong-Zhang
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with DBv3.0 shiojiri data. LGTM.
Guolong-Zhang
approved these changes
Oct 24, 2023
miursh
changed the title
fix(deeoen_to_t4): handling non keyframe sample
fix(deepen_to_t4): handling non keyframe in sample
Oct 24, 2023
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
miursh
force-pushed
the
fix/non_keyframe_sample_token
branch
from
November 21, 2023 19:05
977f02f
to
c6ffc7a
Compare
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
miursh
force-pushed
the
fix/non_keyframe_sample_token
branch
from
November 23, 2023 05:41
084ea1e
to
85e7ce1
Compare
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
miursh
force-pushed
the
fix/non_keyframe_sample_token
branch
from
December 5, 2023 16:36
91fca50
to
0457627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to review
try Deepen_to_t4 conversion and confirm that
How to test
test data
test command
Reference
Notes for reviewer