Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance surface category handling in AnnotationFilesGenerator and DeepenToT4Converter #180

Merged

Conversation

miursh
Copy link
Collaborator

@miursh miursh commented Dec 17, 2024

Description

This pull request includes changes to the perception_dataset module, particularly focusing on handling surface categories in the dataset conversion process. The most important changes include importing the yaml module, updating the constructor and methods to handle surface categories, and modifying the annotation file generation process.

Handling surface categories:

Filtering annotations based on surface categories:

@miursh miursh requested a review from ktro2828 December 17, 2024 17:19
Signed-off-by: Shunsuke Miura <[email protected]>
@miursh miursh force-pushed the feat/update_surface_handling branch from 7f0ab5b to e386a3e Compare December 17, 2024 17:22
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit c1ff9ea into feat/update-dataset-with-fastlabel Dec 19, 2024
5 checks passed
@miursh miursh deleted the feat/update_surface_handling branch December 19, 2024 00:51
ktro2828 added a commit that referenced this pull request Jan 2, 2025
…#172)

* feat: add T4 updater from FastLabel annotations

Signed-off-by: ktro2828 <[email protected]>

* fix: update conversion

Signed-off-by: ktro2828 <[email protected]>

* test: update tests

Signed-off-by: ktro2828 <[email protected]>

* feat: update FastLabel merger (#178)

* update configs

Signed-off-by: Shunsuke Miura <[email protected]>

* add label converter to FastLabel2dToT4Converter

Signed-off-by: Shunsuke Miura <[email protected]>

* fix bug in from_json of surface_ann

Signed-off-by: Shunsuke Miura <[email protected]>

* add automatic_annotation key to sample_annotation/object_ann/surface_ann

Signed-off-by: Shunsuke Miura <[email protected]>

* accelerate default object_mask generation

Signed-off-by: Shunsuke Miura <[email protected]>

* feat: improve T4 updater functionality and directory handling

Signed-off-by: Shunsuke Miura <[email protected]>

* feat: support polygon-to-bbox conversion and improve polygon-to-RLE conversion

* update object config

Signed-off-by: Shunsuke Miura <[email protected]>

* feat: update annotation loader

* feat: only convert to bbox for objects labels

Signed-off-by: Shunsuke Miura <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: handling automatic_annotation entry

Signed-off-by: Shunsuke Miura <[email protected]>

* fix: bug fix in rle_from_points

Signed-off-by: Shunsuke Miura <[email protected]>

* fix: add default value for automatic_annotation

Signed-off-by: Shunsuke Miura <[email protected]>

---------

Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: enhance surface category handling in AnnotationFilesGenerator and DeepenToT4Converter (#180)

* feat: enhance surface category handling in AnnotationFilesGenerator and DeepenToT4Converter

Signed-off-by: Shunsuke Miura <[email protected]>

* delete unnecessary import

Signed-off-by: Shunsuke Miura <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor: parallelizate fl annotation processing  (#182)

* feat: enhance surface category handling in AnnotationFilesGenerator and DeepenToT4Converter

Signed-off-by: Shunsuke Miura <[email protected]>

# Conflicts:
#	perception_dataset/deepen/deepen_to_t4_converter.py
#	perception_dataset/fastlabel_to_t4/fastlabel_2d_to_t4_converter.py
#	perception_dataset/t4_dataset/annotation_files_generator.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor: parallelizate fl annotation processing

Signed-off-by: Shunsuke Miura <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* remove duplicate key in object.yaml

Signed-off-by: Shunsuke Miura <[email protected]>

* feat(fastalbel_to_t4dataset): fix keyframe handling (#187)

* merge _load_annotation_jsons function to one

Signed-off-by: Shunsuke Miura <[email protected]>

* add default value for automatic_annotation

Signed-off-by: Shunsuke Miura <[email protected]>

* change to non-keyframe for no-annotation frame

Signed-off-by: Shunsuke Miura <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove unused import

Signed-off-by: Shunsuke Miura <[email protected]>

---------

Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* change import path

Signed-off-by: Shunsuke Miura <[email protected]>

* Revert "refactor: parallelizate fl annotation processing  (#182)"

This reverts commit 3872c99.

* refactor: FastLabel annotation processing for parallel execution

Signed-off-by: Shunsuke Miura <[email protected]>

* supress no-3D annotation warning

Signed-off-by: Shunsuke Miura <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants