feat: drs conversion #177
Merged
feat: drs conversion #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
- Modify _generate_image_data to accept both np.ndarray and CompressedImage types - Add image_shape parameter to properly set image dimensions - Ensure correct saving of CompressedImage data Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
# Conflicts: # perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py
for more information, see https://pre-commit.ci
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
…on_dataset into feat/drs_conversion # Conflicts: # perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
# Conflicts: # .github/workflows/build-and-test.yaml # perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py # perception_dataset/t4_dataset/classes/ego_pose.py
This reverts commit eea021d.
This reverts commit d45d573.
miursh
force-pushed
the
feat/drs_conversion
branch
from
db5858f to
641e81e
Compare
ktro2828
requested changes
Dec 10, 2024
perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kotaro Uetake <[email protected]>
Signed-off-by: Shunsuke Miura <[email protected]>
…on_dataset into feat/drs_conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several changes to enhance the functionality and performance of the rosbag2 to non-annotated T4 data conversion process.
The main changes include the addition of new sensor channels, performance improvements, and better error handling.
Main Changes
Enhancements to sensor configuration and conversion process:
config/convert_rosbag2_to_non_annotated_t4_drs.yaml: Added configuration for converting rosbag2 to non-annotated T4 format, including new camera sensor channels and settings for handling LiDAR and camera data.perception_dataset/constants.py: Added new camera sensor channelsCAM_BACK_NARROWandCAM_BACK_WIDEto theSENSOR_ENUMclass.perception_dataset/utils/rosbag2.py: Enhanced thepointcloud_msg_to_numpyfunction to includelidar_indexin the resulting numpy array if available.Miscellaneous
Performance improvements:
perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py: Increased the message display interval from 10 to 100 to reduce the frequency of logging during conversion.Added timing measurements to log the elapsed time for different stages of the conversion process, including the total conversion time, LiDAR conversion time, and individual camera conversion times. [1] [2] [3] [4] [5] [6]
perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py: Imported thetimemodule to measure elapsed time during the conversion process.Error handling and logging improvements:
perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py: Improved error handling during the conversion process by catching exceptions and logging errors without stopping the entire conversion.Added separator lines in the log output to improve readability.