-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: camera images convertion #15
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagdalenaKotynia
changed the title
Camera images convertion
fix: camera images convertion
Aug 21, 2023
MagdalenaKotynia
changed the title
fix: camera images convertion
fix : camera images convertion
Aug 22, 2023
MagdalenaKotynia
changed the title
fix : camera images convertion
fix!: camera images convertion
Aug 22, 2023
MagdalenaKotynia
changed the title
fix!: camera images convertion
feat!: camera images convertion
Sep 11, 2023
boczekbartek
changed the title
feat!: camera images convertion
feat: camera images convertion
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MagdalenaKotynia I can see that tests are failing in the CI. Could you try to fix it? I'll review the code when tests will work. Thanks!
This reverts commit 3cd22a7.
MagdalenaKotynia
force-pushed
the
camera_images_convertion
branch
from
September 12, 2023 15:29
7367eb5
to
e25f1a0
Compare
MagdalenaKotynia
force-pushed
the
camera_images_convertion
branch
from
September 13, 2023 09:55
d67098d
to
f044b94
Compare
The #24 PR is a cleaned-up version of this outdated PR so it can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains changes needed to convert rosbags to t4dataset with camera images and annotations (including 2d bounding boxes annotations in object_ann.json file).
How to review
How to test
test data
Example test rosbag
Example test config yaml file:
test command
Reference
Notes for reviewer