Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: camera images convertion #15

Closed
wants to merge 18 commits into from

Conversation

MagdalenaKotynia
Copy link
Contributor

@MagdalenaKotynia MagdalenaKotynia commented Aug 21, 2023

Description

This PR contains changes needed to convert rosbags to t4dataset with camera images and annotations (including 2d bounding boxes annotations in object_ann.json file).

How to review

How to test

test data

Example test rosbag

Example test config yaml file:

task: convert_rosbag2_to_t4
description:
  scene: synthetic
conversion:
  input_base: <path to rosbags directory>
  output_base: <path to output directory>
  workers_number: 1
  skip_timestamp: 2.0
  num_load_frames: 200
  crop_frames_unit: 50  
  camera_latency_sec: 0.00
  object_topic_name: /ground_truth/objects
  object_msg_type: TrackedObjects
  world_frame_id: world
  lidar_sensor:
    topic: /lidar/concatenated/pointcloud
    channel: LIDAR_CONCAT
  camera_sensors: 
    - topic: /sensing/camera/camera4/image_rect_color
      channel: CAM_FRONT
    - topic: /sensing/camera/camera5/image_rect_color
      channel: CAM_BACK

test command

python -m perception_dataset.convert --config <path to config yaml file>

Reference

Notes for reviewer

@MagdalenaKotynia MagdalenaKotynia changed the title Camera images convertion fix: camera images convertion Aug 21, 2023
@MagdalenaKotynia MagdalenaKotynia changed the title fix: camera images convertion fix : camera images convertion Aug 22, 2023
@MagdalenaKotynia MagdalenaKotynia changed the title fix : camera images convertion fix!: camera images convertion Aug 22, 2023
@MagdalenaKotynia MagdalenaKotynia changed the title fix!: camera images convertion feat!: camera images convertion Sep 11, 2023
@boczekbartek boczekbartek changed the title feat!: camera images convertion feat: camera images convertion Sep 11, 2023
@MagdalenaKotynia MagdalenaKotynia marked this pull request as ready for review September 11, 2023 18:29
Copy link
Contributor

@boczekbartek boczekbartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagdalenaKotynia I can see that tests are failing in the CI. Could you try to fix it? I'll review the code when tests will work. Thanks!

@MagdalenaKotynia MagdalenaKotynia marked this pull request as draft September 11, 2023 18:41
@MagdalenaKotynia
Copy link
Contributor Author

The #24 PR is a cleaned-up version of this outdated PR so it can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants