Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge ground segmentation evaluator #55

Merged
merged 11 commits into from
Nov 29, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Nov 26, 2024

Types of PR

  • New Features

Description

How to review this PR

Changes from v1

  • t4_dataset directory is no longer needed
    • Place dataset directly in the same hierarchy as scenario
  • launch argument of sensing is changed from default false to true
    • If you want to use concatenated/pointcloud in bag, you need to explicitly specify sensing:=false as launch argument.
  • The default output directory for simulaion results is now the out directory of the same directory as scenario.
  • Map are placed in a t4_dataset.
    • It is no longer possible to specify in LocalMapPath in the scenario
~/dlr2_data/ground_segmentation
❯ tree . -L 2
.
├── out
│   ├── 2024-1126-134606
│   └── latest -> /home/hyt/dlr2_data/ground_segmentation/out/2024-1126-134606
├── sample_dataset
│   ├── annotation
│   ├── data
│   ├── input_bag
│   └── map
├── scenario_annotated_pcd.yaml
└── scenario_annotated_rosbag.yaml

ros2 launch driving_log_replayer_v2 driving_log_replayer_v2.launch.py scenario_path:=$HOME/dlr2_data/ground_segmentation/scenario_annotated_rosbag.yaml sensing:=false

Others

Do not squash and merge.
Use merge commit

Copy link

sonarcloud bot commented Nov 26, 2024

@badai-nguyen
Copy link
Contributor

@hayato-m126 thank you for your PR.
I confirmed that this PR create a similar result as tier4/driving_log_replayer#528 with option sensing:=false
[INFO] [launch.user]: check_launch_component(conf)={'sensing': False, 'localization': 'false', 'perception': 'true', 'planning': 'false', 'control': 'false'}
However, It seems LaunchSensing: False cannot be set from scenario.yml file so I create a PR to fix it. Could you review it?

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayato-m126 hayato-m126 merged commit 5a2c004 into develop Nov 29, 2024
9 checks passed
@hayato-m126 hayato-m126 deleted the feat/merge-ground-segmentation-evaluator branch November 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants