Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: #498 apply t4 dataset for all evaluations #513

Merged
merged 25 commits into from
Jul 16, 2024
Merged

feat!: #498 apply t4 dataset for all evaluations #513

merged 25 commits into from
Jul 16, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Jul 8, 2024 •
edited
Loading

Types of PR

  • New Features

Description

Breaking Changes

  • Changed to use t4_dataset for all evaluations
  • change package name

How to review this PR

I would like to have a review of the document update.
I have updated Quick Start and would like reviewers to try to follow the instructions.

git checkout feat/#498-apply-t4-dataset-for-all-evaluations
pip3 install mkdocs mkdocs-material mkdocs-awesome-pages-plugin mkdocs-static-i18n mdx-truly-sane-lists
mkdocs serve
# access http://localhost:8000 with your brower

Others

@hayato-m126 hayato-m126 changed the base branch from develop to log_evaluator July 8, 2024 17:14
@hayato-m126 hayato-m126 force-pushed the feat/#498-apply-t4-dataset-for-all-evaluations branch from 84833c6 to c532feb Compare July 9, 2024 04:24
@hayato-m126 hayato-m126 force-pushed the feat/#498-apply-t4-dataset-for-all-evaluations branch from c532feb to 138c3d1 Compare July 9, 2024 04:27
SakodaShintaro
SakodaShintaro reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still reviewing, but I made a few minor points.

docs/quick_start/setup.en.md Outdated Show resolved Hide resolved
docs/quick_start/run.en.md Outdated Show resolved Hide resolved
log_evaluator_migration_tool/README.md Outdated Show resolved Hide resolved
SakodaShintaro
SakodaShintaro requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the migration tool to convert the data and scenario yaml files, and confirmed that the log_evaluator works properly. 👍
I think this is a good improvement.

If you fix the points I have raised, I will approve this PR.

log_evaluator_migration_tool/log_evaluator_migration_tool.py Outdated Show resolved Hide resolved
docs/scenario_format/index.ja.md Outdated Show resolved Hide resolved
@hayato-m126 hayato-m126 force-pushed the feat/#498-apply-t4-dataset-for-all-evaluations branch from 71d53e8 to f55225d Compare July 12, 2024 10:03
@hayato-m126 hayato-m126 force-pushed the feat/#498-apply-t4-dataset-for-all-evaluations branch from f55225d to 3fc90eb Compare July 12, 2024 10:16
SakodaShintaro
SakodaShintaro approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments.
Looks Good To Me

@hayato-m126 hayato-m126 merged commit ea2af43 into log_evaluator Jul 16, 2024
4 checks passed
@hayato-m126 hayato-m126 deleted the feat/#498-apply-t4-dataset-for-all-evaluations branch July 16, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@TakahiroNISHIOKA TakahiroNISHIOKA Awaiting requested review from TakahiroNISHIOKA

@TadaKazuto TadaKazuto Awaiting requested review from TadaKazuto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayato-m126 @SakodaShintaro