Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(traffic_light): support regulatory elements #73

Merged
merged 33 commits into from
May 28, 2024
Merged

feat(traffic_light): support regulatory elements #73

merged 33 commits into from
May 28, 2024

Conversation

ktro2828
Copy link
Collaborator

Category

  • Perception
    • Classification

What

Type of change

  • New feature

Test performed

  • test.sensing_lsim
  • test.perception_lsim

Reference

Notes for reviewer

@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from cec4541 to 8015438 Compare June 20, 2023 11:07
@ktro2828 ktro2828 changed the title Feat/regulatory element fix(traffic_light): support regulatory elements Jun 20, 2023
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from 007f4f6 to c614f64 Compare June 27, 2023 01:51
@ktro2828 ktro2828 changed the title fix(traffic_light): support regulatory elements feat(traffic_light): support regulatory elements Jul 3, 2023
@ktro2828 ktro2828 linked an issue Jul 4, 2023 that may be closed by this pull request
perception: add support of new traffic light interface tier4/driving_log_replayer#149
Closed
@ktro2828 ktro2828 linked an issue Jul 12, 2023 that may be closed by this pull request
[TODO]: Add support of regulatory_element for a set of traffic lights #68
Closed
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from cfcd3df to ae78890 Compare July 31, 2023 12:00
ktro2828 and others added 8 commits November 1, 2023 08:32
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from 4bf71b7 to a759eb0 Compare October 31, 2023 23:36
@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2023
@ktro2828
feat: add support of labels for crosswalk traffic light
d54a1ba 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
fix: update to assign same uuid
d151f81 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
fix: update to avoid error
aa568e3 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
feat: update to merge multiple traffic lights with same uuid
6c02b72 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
revert: remove label of traffic light for crossswalk
b41e743 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
fix: remove checking label while matching objects for classification
0d096b2 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
feat: update matching policy as same label first
adf88b7 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
test: fix label test for TLR
97f9e2d 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828
Merge remote-tracking branch 'origin/feat/regulatory-element' into fe…
faf73b7 
…at/regulatory-element
@ktro2828
fix: TODO update matching policy
2e9acb7 
Signed-off-by: ktro2828 <[email protected]>
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from d80327a to 2e9acb7 Compare December 28, 2023 00:21
@ktro2828 ktro2828 marked this pull request as ready for review May 1, 2024 09:16
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from bea0556 to cc00495 Compare May 14, 2024 01:50
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from cc00495 to 340679a Compare May 14, 2024 02:04
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from 987c76e to 551cd82 Compare May 23, 2024 04:10
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from 551cd82 to 1cf9c50 Compare May 23, 2024 04:10
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from 1b12dd7 to a6f7cce Compare May 23, 2024 05:44
hayato-m126
hayato-m126 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayato-m126 hayato-m126 mentioned this pull request May 24, 2024
Merged
1 task
@ktro2828 ktro2828 force-pushed the feat/regulatory-element branch from 7b5d848 to b354e8a Compare May 28, 2024 00:35
@ktro2828 ktro2828 merged commit ce15e7d into develop May 28, 2024
6 checks passed
@ktro2828 ktro2828 deleted the feat/regulatory-element branch May 28, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayato-m126 hayato-m126 hayato-m126 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@ktro2828 @hayato-m126 @miursh