Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter classes in object count for distance #72

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

pawel-kotowski
Copy link
Contributor

@pawel-kotowski pawel-kotowski commented Jun 1, 2023

Category

  • Perception
    • Detection
    • Tracking
    • Prediction
    • Classification
  • Sensing
  • Other

What

Minor fix to show only bars of classes listed in class_names (in object counts by distance plot).

Type of change

  • New feature
  • [ x] Bug fix
  • Breaking change
  • Refactoring
  • Change code style
  • Update test
  • Update document
  • Chore

Test performed

Generation of plots before and after change.

There are cars, pedestrians and trucks in tested scene and plots are generated with class_names = ["car", "pedestrian", "bicycle", "bus"]

Plot generated without filtering:

  • truck is also included despite not being listed in class_names
  • bicycle and bus class is visible with no objects. This would be ok, but if we put bus or bicycle as first or last in class_names list, then they are not visible on plot. So due to inconsistent behaviour this is also changed and objects with count>0 are not visible.
    image

Plot generated with filtering:
image

  • test.sensing_lsim



  • test.perception_lsim



Reference

Notes for reviewer

@pawel-kotowski pawel-kotowski changed the title Filter classes in object count for distance feat: filter classes in object count for distance Jun 1, 2023
@pawel-kotowski pawel-kotowski changed the title feat: filter classes in object count for distance fix: filter classes in object count for distance Jun 1, 2023
@yukke42 yukke42 requested a review from ktro2828 June 7, 2023 01:18
Copy link
Collaborator

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawel-kotowski Thanks for your PR. It looks good to me.

@Shin-kyoto Do you have any comments or suggestions?

@pawel-kotowski pawel-kotowski force-pushed the fix/eda_filter_classes_in_object_count_dist branch from 7beb31b to 0bf6aea Compare June 26, 2023 19:26
Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants