Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perception): add option on TLR in order to perform whether uuid check first or not. #189

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat(perception): add option on TLR in order to perform whether uuid check first or not. #189

merged 4 commits into from
Oct 2, 2024

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Sep 28, 2024 •
edited
Loading

Category

  • Perception
    • Detection
    • Tracking
    • Prediction
    • Classification
  • Sensing
  • Other

What

This PR add option to perform whether uuid check first or not.

Type of change

  • New feature
  • Bug fix
  • Breaking change
  • Refactoring
  • Change code style
  • Update test
  • Update document
  • Chore

Test performed

  • test.sensing_lsim
  • test.perception_lsim

Reference

Notes for reviewer

I have checked this PR on DLR.

@MasatoSaeki
add patch
4003fda 
Signed-off-by: MasatoSaeki <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Sep 28, 2024
@MasatoSaeki MasatoSaeki marked this pull request as ready for review September 30, 2024 02:42
@MasatoSaeki
change variable name
e78d734 
Signed-off-by: MasatoSaeki <[email protected]>
ktro2828
ktro2828 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@MasatoSaeki MasatoSaeki enabled auto-merge (squash) October 2, 2024 04:55
@MasatoSaeki MasatoSaeki merged commit c3255c8 into develop Oct 2, 2024
7 checks passed
@MasatoSaeki MasatoSaeki deleted the feat/add_uuid_option_tlr branch October 2, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktro2828 ktro2828 ktro2828 approved these changes

@TadaKazuto TadaKazuto Awaiting requested review from TadaKazuto

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasatoSaeki @ktro2828