Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gt frame interpolation function #120

Merged
merged 10 commits into from
Feb 6, 2024
Merged

feat: add gt frame interpolation function #120

merged 10 commits into from
Feb 6, 2024
+441 −6

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jan 16, 2024 •
edited
Loading

Category

  • Perception
    • Detection
    • Tracking
    • Prediction
    • Classification
  • Sensing
  • Other

What

Add GT frame interpolation function.

  • Search before/after GT frames with given unix time and time difference condition
  • If the same uuid object found in both frames, apply linear interpolation
  • Default search bound is 75ms, so smaller time difference (roughly 15ms) will not be interpolated

Type of change

  • New feature
  • Bug fix
  • Breaking change
  • Refactoring
  • Change code style
  • Update test
  • Update document
  • Chore

Test performed

  • test.sensing_lsim
  • test.perception_lsim

Reference

Notes for reviewer

@github-actions github-actions bot added the enhancement New feature or request label Jan 16, 2024
@YoshiRi YoshiRi force-pushed the feat/enable_to_interpolate_ground_truth_frame branch from 21f0fd2 to 6c5dcbd Compare January 25, 2024 01:11
@YoshiRi YoshiRi requested a review from miursh January 25, 2024 01:11
@YoshiRi YoshiRi marked this pull request as ready for review January 25, 2024 01:12
@YoshiRi YoshiRi requested a review from ktro2828 January 25, 2024 01:15
ktro2828
ktro2828 reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks your PR. I commented some minor points.
The code looks good to me.

perception_eval/perception_eval/common/geometry.py Outdated Show resolved Hide resolved
perception_eval/perception_eval/common/geometry.py Outdated Show resolved Hide resolved
perception_eval/perception_eval/common/geometry.py Outdated Show resolved Hide resolved
@YoshiRi YoshiRi force-pushed the feat/enable_to_interpolate_ground_truth_frame branch from 637c0ab to 2c0d1a8 Compare January 25, 2024 05:13
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jan 25, 2024

@ktro2828
Thanks for your review. Spellings are fixed in 2c0d1a8.

ktro2828
ktro2828 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) January 29, 2024 09:07
@YoshiRi YoshiRi merged commit 0d8b28a into develop Feb 6, 2024
21 checks passed
@YoshiRi YoshiRi deleted the feat/enable_to_interpolate_ground_truth_frame branch February 6, 2024 07:40
@YoshiRi YoshiRi mentioned this pull request Feb 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktro2828 ktro2828 ktro2828 approved these changes

@miursh miursh Awaiting requested review from miursh

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoshiRi @ktro2828 @miursh