Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diag): use tier4 diag graph settings #705

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Dec 9, 2024

Description

As the vanilla pilot-auto, we have decided to use tier4 original settings different from awf sample settings, hence I had merged fork PR #698.

However, by the mistake of resolving conflict against the awf, part of #698 is reverted.
#701
#702

This PR fixes the above miss of resolve.

Tests performed

psim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yuki-takagi-66 <[email protected]>
Copy link

github-actions bot commented Dec 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review December 9, 2024 05:27
@yuki-takagi-66 yuki-takagi-66 merged commit 8a8f9c8 into awf-latest Dec 9, 2024
17 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/diag/use-tier4-settings branch December 9, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant