forked from autowarefoundation/autoware_launch
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diag): build tier4 diag settings #699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takagi-66
changed the title
feat(diag): build tier4 settings
feat(diag): build tier4 diag settings
Dec 2, 2024
SakodaShintaro
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed the following tests.
-
logging_simulator
-
e2e_simulator
with AWSIM v1.3.1 - An emergency stop occurs when ekf publishes an ERROR level diagnostic.
I also checked the localization and mapping yaml files.
LGTM
I visualized trees by tree-tool. |
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
yuki-takagi-66
force-pushed
the
takagi/diag/build-tier4-settings
branch
from
December 9, 2024 06:17
b76cd72
to
87bb0fa
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: yuki-takagi-66 <[email protected]>
yuki-takagi-66
force-pushed
the
takagi/diag/build-tier4-settings
branch
from
December 9, 2024 06:22
bdc4910
to
250c8cf
Compare
4 tasks
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides tier4 common diag settings.
Most of all are copied from x2 v3.1 settings.
Related links
part of autowarefoundation#1221
Tests performed
psim and scenario tests
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.