Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diag): build tier4 diag settings #699

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

yuki-takagi-66
Copy link

@yuki-takagi-66 yuki-takagi-66 commented Dec 2, 2024

Description

This PR provides tier4 common diag settings.
Most of all are copied from x2 v3.1 settings.

Related links

part of autowarefoundation#1221

Tests performed

psim and scenario tests

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed the following tests.

  • logging_simulator
  • e2e_simulator with AWSIM v1.3.1
  • An emergency stop occurs when ekf publishes an ERROR level diagnostic.

I also checked the localization and mapping yaml files.
LGTM

@SakodaShintaro
Copy link

I visualized trees by tree-tool.

autoware-main_tree.txt
autoware-awsim_tree.txt

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/diag/build-tier4-settings branch from b76cd72 to 87bb0fa Compare December 9, 2024 06:17
Copy link

github-actions bot commented Dec 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/diag/build-tier4-settings branch from bdc4910 to 250c8cf Compare December 9, 2024 06:22
@yuki-takagi-66 yuki-takagi-66 merged commit ac972ab into awf-latest Dec 9, 2024
11 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/diag/build-tier4-settings branch December 9, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants