Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_vehicle_cmd_gate): prevent steering when vehicle stopping. #1660

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mkuri
Copy link

@mkuri mkuri commented Nov 22, 2024

Description

Prevent steering when vehicle stopping.

本当の原因はadapiから発行されたpause serviceがvehicle cmd gateで反映されていなさそうなのが問題で、その原因が分かっていない。
暫定対策としてtier/autoware.universeにどの状態でもstop modeでは操舵を使わないようにするoptionを追加します。ただし走行中にstop modeに遷移すると操舵が効かなくなるデグレがありますが、高頻度で据え切りしてしまうより良いと考えての暫定対策。

Related links

https://tier4.atlassian.net/browse/RT0-34156
https://tier4.atlassian.net/browse/RT0-34158

https://star4.slack.com/archives/C074CCKN35E/p1730966121326069

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri merged commit 2253336 into beta/x2_gen2/v0.29.0 Nov 22, 2024
24 of 25 checks passed
@mkuri mkuri deleted the chore/not-steering-when-stop branch November 22, 2024 20:10
mkuri added a commit that referenced this pull request Nov 26, 2024
…ng. (#1660)

chore(autoware_vehicle_cmd_gate): prevent steering when stop

Signed-off-by: Makoto Kurihara <[email protected]>
TetsuKawa pushed a commit that referenced this pull request Dec 1, 2024
…ng. (#1660)

chore(autoware_vehicle_cmd_gate): prevent steering when stop

Signed-off-by: Makoto Kurihara <[email protected]>
TetsuKawa pushed a commit that referenced this pull request Jan 23, 2025
…ng. (#1660)

chore(autoware_vehicle_cmd_gate): prevent steering when stop

Signed-off-by: Makoto Kurihara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants