Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): reject candidate path whose start pose direction is not aligned with ego path (#6935) #1296

Merged
merged 1 commit into from
May 15, 2024

Conversation

soblin
Copy link

@soblin soblin commented May 14, 2024

Description

autowarefoundation#6935

Related links

https://tier4.atlassian.net/browse/RT1-5675

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmpwk shmpwk changed the base branch from beta/v0.20.1.6 to beta/v0.20.1.8 May 14, 2024 13:56
@shmpwk shmpwk merged commit 8d6d830 into beta/v0.20.1.8 May 15, 2024
22 of 25 checks passed
@shmpwk shmpwk deleted the v0.20.1.6+PR6935 branch May 15, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants