Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ignorePaths): ignore .so extension #629

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

lexavtanke
Copy link
Contributor

There are model files with .so extension in tvm_utility package with PR. They are binary files and produce many warnings during the spell-check.

@lexavtanke lexavtanke marked this pull request as draft October 18, 2023 11:09
@lexavtanke lexavtanke marked this pull request as ready for review October 18, 2023 11:09
@lexavtanke
Copy link
Contributor Author

@HansRobo Hi, sorry for bothering you but I don't now whom should I add to review this PR (and I don't have right anyway). And I saw that you review many of them before. Please, can you review it?

Thank you in advance.

@HansRobo HansRobo self-requested a review October 19, 2023 08:29
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
I think the change makes sense.

@HansRobo HansRobo enabled auto-merge (squash) October 19, 2023 08:31
@HansRobo HansRobo merged commit e1a0e66 into tier4:main Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants