feat: intrinsic_evaluation_mode_visual_indicators #213
Conversation
…g elements for eval mode
…and calibration parameters into a file, change ui elements in eval mode.
SergioReyesSan
changed the title
SergioReyesSan
changed the title
|
@SergioReyesSan |
|
From now now, please follow conventional commits as well Also, please sign you commits with |
| @@ -136,6 +136,9 @@ def load_intrinsics_button_callback(): | |||
| ) | |||
| self.initial_intrinsics = load_intrinsics(intrinsics_path) | |||
| self.evaluation_radio_button.setEnabled(True) | |||
| # self.training_radio_button.setChecked(False) | |||
There was a problem hiding this comment.
Can you delete this commented line?
|
note: for this PR or the next, the distortion model and the number of coefficients is not being handled correctly in I/O |
| print(calibrator_type.value["name"], flush=True) | ||
| calib_params = self.calibrator_dict[calibrator_type].parameters_value() | ||
| with open(filename, "w") as file: | ||
| yaml.dump({"board_parameters": board_params}, file, default_flow_style=False) |
There was a problem hiding this comment.
I think it is better to perform a single dump of a dictionary containing all the elements
|
@SergioReyesSan |
|
Replaced by the new PR |
Description
The proposed features in this PR are:
Add some UI elements to the main window, indicating useful information like: speed, angles, and aspect ratio of the board, as well as indicators for the samples added according to the board size and skew angle.
Fix bugs when reading intrinsic parameter files.
Add a linearity heatmap to check the image distortion using the calibration board.
Save the training and evaluation points used for calibration and the parameters used in a file.
Loading the intrinsics file enables the evaluation mode, which, by default, modifies the elements shown on the main UI.
Related links
No related links for now.
Tests performed
Tested with rosbags that contain chessboard and dot calibration boards, however, some parameters need to be adjusted like the percentage for color transition in skew and size indicators for real-time detections.
Notes for reviewers
Some parameters need to be adjusted like the color transition for skew and size indicators for real-time detections.
Angle filtering and some extra filtering might be needed.
I have tried to delete spaces on empty lines however I might skipped some of them.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.