fix(sensor_calibration_manager): fixed sensor calibration manager related issues #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
vividf
requested changes
May 1, 2024
sensor/sensor_calibration_manager/sensor_calibration_manager/calibrator_base.py
Outdated
Show resolved
Hide resolved
sensor/sensor_calibration_manager/sensor_calibration_manager/sensor_calibration_manager.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
|
@vividf |
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
|
@knzo25 |
…tion tools Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
|
@vividf Thanks for the check ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon the release of the new api, two problems were encountered:
Related links
Tickets:
Tests performed
After the
Launcher configurationwidget, the sensor calibration manager executes the respective launchers. In this condition, even if we close the sensor calibration manager via widget or console, no zombies remain(can be checked with
ps -aux | grep ros) or similarPreviously, if we ran the sensor calibration manager until after the launchers were executed with no autoware nor rosbag (which publishes the /tf_static), even if we started autoware or the rosbag afterwards, the calibration tool never became able to calibrate due to the design of the internal state machine. With this PR, is should be fixed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.