Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base documentation for lidar-lidar, lidar-camera, lidar-radar #165

Merged
merged 12 commits into from
Apr 23, 2024

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Apr 22, 2024

Description

Base documentation for lidar-lidar, lidar-camera, lidar-radar are done.

Note: I also remove some unused variables.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@knzo25
Copy link
Collaborator

knzo25 commented Apr 22, 2024

@vividf
As mentioned before in the internal channel, push documentation in the branch I prepared. Do not create a different branch

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feature/new_api_documentation@a8a4b6a). Click here to learn what that means.

Files Patch % Lines
...ier4_ground_plane_utils/src/ground_plane_utils.cpp 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                       Coverage Diff                       @@
##             feature/new_api_documentation    #165   +/-   ##
===============================================================
  Coverage                                 ?   0.00%           
===============================================================
  Files                                    ?      69           
  Lines                                    ?    7652           
  Branches                                 ?     758           
===============================================================
  Hits                                     ?       0           
  Misses                                   ?    7652           
  Partials                                 ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vividf vividf merged commit 2577298 into tier4:feature/new_api_documentation Apr 23, 2024
3 of 8 checks passed
@vividf vividf deleted the document/new_api branch July 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants