-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deviation_evaluator): fix bug in map launch and plot #143
fix(deviation_evaluator): fix bug in map launch and plot #143
Conversation
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## tier4/universe #143 +/- ##
=================================================
- Coverage 0.95% 0.00% -0.96%
=================================================
Files 269 4 -265
Lines 20908 142 -20766
Branches 387 0 -387
=================================================
- Hits 200 0 -200
+ Misses 20551 142 -20409
+ Partials 157 0 -157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
LGTM but please fix the CI/CD's error |
Signed-off-by: kminoda <[email protected]>
@YamatoAndo Thank you, fixed: 7b9f40c |
Description
Related links
None
Tests performed
Launched deviation_evaluator and confirmed that the outputs are properly generated.
Notes for reviewers
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.