Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deviation_evaluator): fix bug in map launch and plot #143

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 14, 2023

Description

  • Fix map launch for incorporating latest map launching configuration
  • Fix ignoring configuration for plotting the expected errors

Related links

None

Tests performed

Launched deviation_evaluator and confirmed that the outputs are properly generated.

Notes for reviewers

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0153ee) 0.95% compared to head (7b9f40c) 0.00%.
Report is 1 commits behind head on tier4/universe.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                @@
##           tier4/universe    #143      +/-   ##
=================================================
- Coverage            0.95%   0.00%   -0.96%     
=================================================
  Files                 269       4     -265     
  Lines               20908     142   -20766     
  Branches              387       0     -387     
=================================================
- Hits                  200       0     -200     
+ Misses              20551     142   -20409     
+ Partials              157       0     -157     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda marked this pull request as ready for review November 14, 2023 07:27
@kminoda kminoda requested a review from YamatoAndo November 14, 2023 07:27
@YamatoAndo
Copy link
Contributor

LGTM but please fix the CI/CD's error

Signed-off-by: kminoda <[email protected]>
@kminoda
Copy link
Contributor Author

kminoda commented Nov 15, 2023

@YamatoAndo Thank you, fixed: 7b9f40c

@kminoda kminoda merged commit 055f7b8 into tier4/universe Nov 15, 2023
6 of 9 checks passed
@knzo25 knzo25 deleted the fix/deviation_evaluator/fix_small_bugs branch June 5, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants