Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deviation_estimator): organize parameters #142

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 8, 2023

Description

Organize parameters

Related links

None

Tests performed

Launched deviation_estimator and confirmed that it generate result files.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda changed the title chore(deviation_estimator): organize parameters feat(deviation_estimator): organize parameters Nov 8, 2023
@kminoda kminoda requested a review from YamatoAndo November 8, 2023 02:45
@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (b0153ee) 0.95% compared to head (0a856f9) 18.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           tier4/universe     #142       +/-   ##
===================================================
+ Coverage            0.95%   18.97%   +18.02%     
===================================================
  Files                 269       14      -255     
  Lines               20908      548    -20360     
  Branches              387      297       -90     
===================================================
- Hits                  200      104       -96     
+ Misses              20551      366    -20185     
+ Partials              157       78       -79     
Flag Coverage Δ
differential 18.97% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ls/deviation_estimator/src/deviation_estimator.cpp 7.65% <0.00%> (+0.12%) ⬆️

... and 255 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit fe3a3cc into tier4/universe Nov 8, 2023
7 of 8 checks passed
@knzo25 knzo25 deleted the chore/organize_parameters branch June 5, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants