Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deviation_estimator): use yaw stddev instead of max for stddev gyro #140

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 25, 2023

Description

For IMU link standard deviation, we would like to use yaw standard deviation in base_link for all the three axes.

This is because the standard deviation estimation of x and y in base_link may not be accurate especially when the data contains a motion when the people are getting on/off the vehicle, which causes the vehicle to tilt in roll and pitch. In this case, we would like to use the standard deviation of yaw axis in base_link.

For instance, the original algorithm caused a very large standard deviation for stddev_angular_*, e.g. 0.9[rad/s], possible due to the tilting motion of the vehicle when the vehicle is stopped.
With this PR, the estimated value is now around 0.006 [rad/s] for the same rosbag, which is closer to it's real standard deviation apparently from the plot.

Related links

None

Tests performed

Tested on our calibration data.

Notes for reviewers

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested a review from YamatoAndo October 25, 2023 09:40
pre-commit-ci bot and others added 2 commits October 25, 2023 09:43
@kminoda kminoda changed the title feat(deviation_estimator): use min instead of max for stddev gyro feat(deviation_estimator): use yaw stddev instead of max for stddev gyro Oct 26, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5035f8e) 0.95% compared to head (0df824c) 18.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           tier4/universe     #140       +/-   ##
===================================================
+ Coverage            0.95%   18.87%   +17.91%     
===================================================
  Files                 269       14      -255     
  Lines               20911      551    -20360     
  Branches              390      301       -89     
===================================================
- Hits                  200      104       -96     
+ Misses              20554      369    -20185     
+ Partials              157       78       -79     
Flag Coverage Δ
differential 18.87% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ls/deviation_estimator/src/deviation_estimator.cpp 7.52% <0.00%> (+0.11%) ⬆️

... and 255 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit b0153ee into tier4/universe Oct 26, 2023
8 of 9 checks passed
@knzo25 knzo25 deleted the feat/deviation_estimator/use_min_instead_of_max_for_stddev branch June 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants