Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update x2 launch file #138

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Oct 19, 2023

Description

X2の車両で行ったアップデートを反映します

  • x2のlaunch fileでimage topicの名前が間違っていたので修正しました
  • camera7の起動ができなかったため起動できる記述を追加しました
  • base lidarで利用するタグに1,2のIDのタグが増えたので追加しました

Related links

Tests performed

camera0,3,6,7でキャリブレーションツールが起動することとrosbagを流して画像・rvizの点群が表示されることを確認しました
baselinktolidarのツールを起動しrosbagを流してすべての1,2のタグが認識されることを確認しました

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yabuta yabuta requested a review from knzo25 October 20, 2023 00:01
@yabuta yabuta marked this pull request as ready for review October 20, 2023 00:01
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabuta yabuta merged commit 5035f8e into tier4/universe Oct 20, 2023
7 of 9 checks passed
@knzo25 knzo25 deleted the feature/fix_image_topic_name_and_add_camera7 branch June 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants