Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gyro_bias_module): small fix about x,y,z #133

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Oct 4, 2023

Description

Fixed a small mistake regarding axes.

Related links

Tests performed

$ colcon build --packages-select deviation_estimator
Starting >>> deviation_estimator
[Processing: deviation_estimator]                             
Finished <<< deviation_estimator [54.3s]                       

Summary: 1 package finished [56.0s]

$ colcon test --packages-select deviation_estimator
Starting >>> deviation_estimator
Finished <<< deviation_estimator [5.83s]          

Summary: 1 package finished [7.17s]

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro SAKODA <[email protected]>
@SakodaShintaro SakodaShintaro requested a review from kminoda October 4, 2023 08:11
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8b5c007) 0.97% compared to head (0c80896) 19.31%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           tier4/universe     #133       +/-   ##
===================================================
+ Coverage            0.97%   19.31%   +18.34%     
===================================================
  Files                 269       14      -255     
  Lines               20904      554    -20350     
  Branches              387      301       -86     
===================================================
- Hits                  203      107       -96     
+ Misses              20547      372    -20175     
+ Partials              154       75       -79     
Flag Coverage Δ
differential 19.31% <33.33%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tools/deviation_estimator/src/gyro_bias_module.cpp 44.18% <33.33%> (-2.16%) ⬇️

... and 255 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SakodaShintaro SakodaShintaro merged commit c79aeea into tier4/universe Oct 4, 2023
8 of 9 checks passed
@knzo25 knzo25 deleted the fix/gyro_biase_module_small_fix branch June 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants