Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x1): add fitness score in calibration.launch and delete default value #129

Merged
merged 7 commits into from
Oct 3, 2023
Merged

feat(x1): add fitness score in calibration.launch and delete default value #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75589e3
feat: add fitness score in calibration.launch and delete default value
yn-mrse Sep 29, 2023
24ca8b9
fix: disable fitness_score for not-map_based user
yn-mrse Sep 29, 2023
8db247c
fix(aip_xx1): default parameter on map_based_sensor_kit
yn-mrse Oct 2, 2023
12865fa
fix(aip_xx1): default parameter on map_based_sensors
yn-mrse Oct 2, 2023
373c039
fix(aip_xx1): remove argument fitness_score on map_based.launch
yn-mrse Oct 2, 2023
e411221
fix(aip_xx1): remove argument fitness_score on map_based
yn-mrse Oct 3, 2023
bc4bf07
fix(aip_xx1): remove argument fitness_score on map_based
yn-mrse Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sensor/extrinsic_calibration_manager/launch/aip_x1/map_based.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<arg name="map_calibration_area_file" default="map_calibration_area.pcd"/>
<arg name="use_calibration_area_map" default="true" />
<arg name="calibration_rviz" default="true"/>
<arg name="fitness_score_threshold" />

<let name="sensor_model" value="aip_x1" />

Expand All @@ -18,6 +19,7 @@
<include file="$(find-pkg-share extrinsic_calibration_manager)/launch/$(var sensor_model)/map_based_sensor_kit.launch.xml">
<arg name="vehicle_id" value="$(var vehicle_id)" />
<arg name="use_calibration_area_map" value="$(var use_calibration_area_map)" />
<arg name="fitness_score_threshold" value="$(var fitness_score_threshold)" />
</include>
</group>

Expand Down
2 changes: 1 addition & 1 deletion sensor/extrinsic_calibration_manager/launch/aip_x1/map_based_sensor_kit.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<let name="input_map_without_wall_topic_name" value="/map/pointcloud_map_without_wall" />
<arg name="use_calibration_area_map" default="true" />
<arg name="accumulate_frame_num" default="3" />
<arg name="fitness_score_threshold" default="0.0005" />
<arg name="fitness_score_threshold" />

<arg name="config_file_name" default="extrinsic_map_based_calib.yaml" />

Expand Down
2 changes: 2 additions & 0 deletions sensor/extrinsic_calibration_manager/launch/aip_x1_1/map_based.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<arg name="map_calibration_area_file" default="map_calibration_area.pcd"/>
<arg name="use_calibration_area_map" default="true" />
<arg name="calibration_rviz" default="true"/>
<arg name="fitness_score_threshold" />

<let name="sensor_model" value="aip_x1_1" />

Expand All @@ -18,6 +19,7 @@
<include file="$(find-pkg-share extrinsic_calibration_manager)/launch/$(var sensor_model)/map_based_sensor_kit.launch.xml">
<arg name="vehicle_id" value="$(var vehicle_id)" />
<arg name="use_calibration_area_map" value="$(var use_calibration_area_map)" />
<arg name="fitness_score_threshold" value="$(var fitness_score_threshold)" />
</include>
</group>

Expand Down
2 changes: 1 addition & 1 deletion sensor/extrinsic_calibration_manager/launch/aip_x1_1/map_based_sensor_kit.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<let name="input_map_without_wall_topic_name" value="/map/pointcloud_map_without_wall" />
<arg name="use_calibration_area_map" default="true" />
<arg name="accumulate_frame_num" default="3" />
<arg name="fitness_score_threshold" default="0.0005" />
<arg name="fitness_score_threshold" />

<arg name="config_file_name" default="extrinsic_map_based_calib.yaml" />

Expand Down
2 changes: 2 additions & 0 deletions sensor/extrinsic_calibration_manager/launch/calibration.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,14 @@
</group>

<group if="$(eval &quot;'$(var mode)' == 'map_based' &quot;)">
<arg name="fitness_score_threshold" />
<include file="$(find-pkg-share extrinsic_calibration_manager)/launch/$(var sensor_model)/map_based.launch.xml">
<arg name="vehicle_id" value="$(var vehicle_id)" />
<arg name="map_path" value="$(var map_path)" />
<arg name="map_calibration_area_file" value="$(var map_calibration_area_file)" />
<arg name="use_calibration_area_map" value="$(var use_calibration_area_map)" />
<arg name="calibration_rviz" value="$(var calibration_rviz)" />
<arg name="fitness_score_threshold" value="$(var fitness_score_threshold)" />
</include>
</group>

Expand Down
Loading