Skip to content

Commit

Permalink
chore: fix function name setDelta
Browse files Browse the repository at this point in the history
Signed-off-by: vividf <[email protected]>
  • Loading branch information
vividf committed Oct 3, 2024
1 parent 8ab4a0c commit 7f7f8e5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class TransformationEstimator
void setPoints(
pcl::PointCloud<common_types::PointType>::Ptr lidar_points_ocs,
pcl::PointCloud<common_types::PointType>::Ptr radar_points_rcs);
void setDelta(double delta_cos, double delta_sin);
void set2DRotationDelta(double delta_cos, double delta_sin);
void estimateYawOnlyTransformation();
void estimateSVDTransformation(
ExtrinsicReflectorBasedCalibrator::TransformationType transformation_type);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1424,7 +1424,7 @@ TransformationResult ExtrinsicReflectorBasedCalibrator::estimateTransformation()

if (transformation_type_ == TransformationType::yaw_only_rotation_2d) {
auto [delta_cos, delta_sin] = get2DRotationDelta(converged_tracks_, false);
estimator.setDelta(delta_cos, delta_sin);
estimator.set2DRotationDelta(delta_cos, delta_sin);
estimator.estimateYawOnlyTransformation();
transformation_result.calibrated_radar_to_lidar_transformation = estimator.getTransformation();
RCLCPP_INFO_STREAM(
Expand Down Expand Up @@ -1601,7 +1601,7 @@ void ExtrinsicReflectorBasedCalibrator::evaluateCombinations(
}
auto [delta_cos, delta_sin] = get2DRotationDelta(crossval_converged_tracks_, true);

crossval_estimator.setDelta(delta_cos, delta_sin);
crossval_estimator.set2DRotationDelta(delta_cos, delta_sin);
crossval_estimator.estimateYawOnlyTransformation();
} else {
crossval_lidar_points_ocs->clear();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ void TransformationEstimator::setPoints(
radar_points_rcs_ = radar_points_rcs;
}

void TransformationEstimator::setDelta(double delta_cos, double delta_sin)
void TransformationEstimator::set2DRotationDelta(double delta_cos, double delta_sin)
{
delta_cos_ = delta_cos;
delta_sin_ = delta_sin;
Expand Down

0 comments on commit 7f7f8e5

Please sign in to comment.