Skip to content

Commit

Permalink
fix more sentences
Browse files Browse the repository at this point in the history
Signed-off-by: vividf <[email protected]>
  • Loading branch information
vividf committed May 7, 2024
1 parent cc75c68 commit 2dee0c5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sensor/docs/tutorials/tag_based_pnp_calibrator.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ The provided rosbag includes four different topics: `camera_info`, `image_rect_c

### Overall calibration environment

The required space for calibration depends on the vehicle and sensors used. During the calibration, please always make sure that tags are detected by both camera and lidar. The user could always check whether the tags appear in the `rviz` and the `image view` UI. For instance, the user can observe the cyan rhombus around the tag in `rviz` if the tag is successfully detected by lidar, as shown in the image below. For the camera, if the tag is visible in the `image view` UI, it should be detectable (so far, there have been no issues).
The required space for calibration depends on the vehicle and sensors used. During the calibration, please always make sure that tags are detected by both camera and lidar. The user could always check whether the tags appear in the `rviz` and the `image view` UI. For instance, he can observe the cyan rhombus around the tag in `rviz` if the tag is successfully detected by lidar, as shown in the image below. For the camera, if the tag is visible in the `image view` UI, it should be detectable (so far, there have been no issues).

<p align="center">
<img src="../images/tag_based_pnp_calibrator/lidar_detection.jpg" alt="lidar_detection">
Expand Down
2 changes: 1 addition & 1 deletion sensor/tag_based_pnp_calibrator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ References/External links

## Pro tips/recommendations

- During calibration, ensure that the lidar scan covers the tag, similar to the first example shown in the image below. However, if the tag resolution is low, as in the second example, and the lidar still detects the tag, it may still be acceptable, but avoidable when possible. The third example demonstrates a scenario where the lidar scan fails to cover the tag, resulting in the inability to detect the lidartag.
- During calibration, ensure that the lidar scan covers the tag, similar to the first example shown in the image below. However, if the tag resolution is low, as in the second example, and the lidar still detects the tag, it may still be acceptable, but should be avoided when possible. The third example demonstrates a scenario where the lidar scan fails to cover the tag, resulting in the inability to detect the lidartag.

<p align="center">
<img src="../docs/images/tag_based_pnp_calibrator/lidarscan_on_tag.jpg" alt="lidarscan_on_tag" width="500">
Expand Down

0 comments on commit 2dee0c5

Please sign in to comment.