Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LiDAR range modifications #376

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve LiDAR range modifications #376

wants to merge 5 commits into from
+1,781 −96

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Dec 16, 2024 •
edited
Loading

This PR:

  • Adds an empty element to the non-uniform range LiDARs to inform how to modify their range
  • Separates high resolution mode of Hesai Pandar128E4X as a new preset to handle lasers modification
    • To implement this, we had to move the high resolution mode to a separate prefab, because the previous implementation always used Laser definitions straight from the code-based specification, so the range changes in the GUI would not be taken into account
Uniform range LiDARs (e.g. VLP16) Non-uniform LiDARs (e.g. Pandar128E4X)
rangeSettings rangeTooltip

@msz-rai msz-rai requested a review from prybicki December 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prybicki prybicki prybicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msz-rai @prybicki