-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rain and fog simulation features #359
Conversation
This reverts commit 5c50072.
* Adjust Plugin to new RGL version * Make skinned models readable * Add new API calls * Perform skinning in RGL * Optimize calculating the pose by caching it for objects that share the same skeleton * Cleanup & docs * Update RGL binaries * Remove unused package import * Review fixes * Update RGL binary for Linux
* Make updates to multi-return and snow simulation. * Remove not used include. * Update LiDAR prefabs to new multi-return. * Add updated RGL binary. * Fix RGL binary. * Change default setting of LiDAR divergence. * Update documentation on multi-return. * Make changes based on review. * Update RGL binaries (#351) * Update RGL Linux binary * Update RGL Windows binary --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
Signed-off-by: Paweł Liberadzki <[email protected]>
This reverts commit 5c50072.
* Make updates to multi-return and snow simulation. * Remove not used include. * Update LiDAR prefabs to new multi-return. * Add updated RGL binary. * Fix RGL binary. * Change default setting of LiDAR divergence. * Update documentation on multi-return. * Make changes based on review. * Update RGL binaries (#351) * Update RGL Linux binary * Update RGL Windows binary --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
… feature/rgl-fog-simulation
Signed-off-by: Paweł Liberadzki <[email protected]>
Make adjustments to rain simulation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional note from runtime testing. Except from this, everything seems to work fine in runtime.
…nto feature/rgl-fog-simulation
Signed-off-by: Paweł Liberadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check this feature in the internal repository.
This code introduces public components for rain and fog simulations. Each simulation can be controlled with dedicated manager (images below).