Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround to Hesai packets axis orientation #220

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add workaround to Hesai packets axis orientation #220

merged 3 commits into from
Nov 21, 2023

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Nov 19, 2023

No description provided.

hosokawa-ikuto
hosokawa-ikuto approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@hosokawa-ikuto hosokawa-ikuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I've tested with my testing scene of Hesai Lidars and it has worked fine.)

mackierx111
mackierx111 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit fa8cb65 into main Nov 21, 2023
2 checks passed
@mackierx111 mackierx111 deleted the fix/hesai-raw-packet-orientation-workaround branch November 21, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

@hosokawa-ikuto hosokawa-ikuto hosokawa-ikuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msz-rai @hosokawa-ikuto @mackierx111