Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RGL to v16 #218

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Upgrade RGL to v16 #218

merged 7 commits into from
Nov 21, 2023

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Nov 10, 2023

  • Updated RGLUnityPlugin to work with RGL v0.16.2
  • Minor fixes:
    • TimeSource is set directly in SceneManager (it was performed in RglLidarPublisher previously)
    • ROS2 topics are not created if RglLidarPublisher component is disabled

@msz-rai msz-rai marked this pull request as ready for review November 13, 2023 15:57
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGL v16 is very nice and faster! I have checked that Autoware self-driving is possible with RGL v16.

The point cloud seems to be displaying incorrectly, can you check what is causing this? I do not know if the actual point cloud output is wrong or just the visualization.

Screenshot from 2023-11-15 02-28-11

@msz-rai
Copy link
Contributor Author

msz-rai commented Nov 15, 2023

@mackierx111
Thank you for the review 🙇‍♂️
There was a bug in the visualization. I have already fixed it.
However, I have found another bug with angular Gaussian noise - its impact on point cloud increases over time when driving. I am still working on that.

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit dff3103 into main Nov 21, 2023
2 checks passed
@mackierx111 mackierx111 deleted the feature/rgl-v16 branch November 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants