Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if running RGLUnityPlugin with sourced ROS2 #203

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Sep 23, 2023

The latest ROS2 release is not working with the RGL standalone build.
RGLUnityPlugin should be running without sourcing ROS2 (the same as Ros2ForUnity plugin).
This PR adds an error message if running RGLUnityPlugin with sourced ROS2.

Related issue: #187

@mackierx111
Copy link
Collaborator

@msz-rai
Is it ok if ros2 is not sourced when using UnityEditor to publish ROS2?
Is there any difference in ROS2 publish/subscribe when running AWSIM with unity player and unity editor?

@msz-rai
Copy link
Contributor Author

msz-rai commented Nov 7, 2023

@mackierx111

Is it ok if ros2 is not sourced when using UnityEditor to publish ROS2?

Yes, because RGL is built in standalone mode (the same as ros2-for-unity). It contains all of the dependent libraries (e.g. ROS2) to run.

Is there any difference in ROS2 publish/subscribe when running AWSIM with unity player and unity editor?

As far as I know, there is no difference.

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit 7a06f8c into main Nov 30, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants