Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to quarto #232

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Convert to quarto #232

merged 9 commits into from
Oct 2, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 2, 2024

Fixes #217

@hadley
Copy link
Member Author

hadley commented Oct 2, 2024

@mine-cetinkaya-rundel is there anything obvious that I've forgotten to convert?

mine-cetinkaya-rundel
mine-cetinkaya-rundel approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@mine-cetinkaya-rundel mine-cetinkaya-rundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't catch anything big, just two minor things that are Quarto alternatives (and current versions would work too).

_quarto.yml
theme:
- styles.scss

knitr:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be

execute:
  eval: false

as well, but either should work.

index.qmd Outdated Show resolved Hide resolved
@hadley @mine-cetinkaya-rundel
Update index.qmd
832cc5c 
Co-authored-by: Mine Cetinkaya-Rundel <[email protected]>
@hadley hadley merged commit adbdbb7 into main Oct 2, 2024
1 check passed
@hadley
Copy link
Member Author

hadley commented Oct 2, 2024

Thanks!

@hadley hadley deleted the quarto branch October 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mine-cetinkaya-rundel mine-cetinkaya-rundel mine-cetinkaya-rundel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to quarto book
2 participants
@hadley @mine-cetinkaya-rundel