Handle dot-prefixed names in custom translation #1530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1529
ls()
calls in thenames.sql_variant()
method.ls_all()
everywhere I could see it, without too careful a reading of whether it may not be appropriate in that case. I fear I don't have context to discriminate which should continue being plainls()
.I could go for an assist on writing a regression test, I couldn't quite put all the pieces together. How do I link a custom translation to a simulated connection?
Also LMK if you want more tests covering the switch to
ls_all()
for the other cases.