fix(ios): fix encoding for some URLs

tidev · Apr 17, 2022 · 40e66bc · 40e66bc
1 parent a3acf46
commit 40e66bc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/ios/Classes/TiWebdialogModule.m b/ios/Classes/TiWebdialogModule.m
@@ -62,7 +62,9 @@ - (void)safariViewControllerDidFinish:(SFSafariViewController *)controller
 - (SFSafariViewController *)safariController:(NSString *)url withEntersReaderIfAvailable:(BOOL)entersReaderIfAvailable andBarCollapsingEnabled:(BOOL)barCollapsingEnabled
 {
   if (_safariController == nil) {
-    NSURL *safariURL = [NSURL URLWithString:[url stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
+    NSString *encodedURL = [url stringByAddingPercentEncodingWithAllowedCharacters:NSCharacterSet.URLQueryAllowedCharacterSet];
+    NSURL *safariURL = [NSURL URLWithString:encodedURL];
+
     if (@available(iOS 11.0, *)) {
       SFSafariViewControllerConfiguration *config = [[SFSafariViewControllerConfiguration alloc] init];
       config.entersReaderIfAvailable = entersReaderIfAvailable;

diff --git a/ios/Classes/TiWebdialogModuleAssets.m b/ios/Classes/TiWebdialogModuleAssets.m
@@ -3,18 +3,20 @@
  */
 #import "TiWebdialogModuleAssets.h"
 
-extern NSData *filterDataInRange(NSData *thedata, NSRange range);
+extern NSData* filterDataInRange(NSData* thedata, NSRange range);
 
 @implementation TiWebdialogModuleAssets
 
 - (NSData *)moduleAsset
 {
+
 
   return nil;
 }
 
 - (NSData *)resolveModuleAsset:(NSString *)path
 {
+
 
   return nil;
 }

diff --git a/ios/manifest b/ios/manifest
@@ -2,7 +2,7 @@
 # this is your module manifest and used by Titanium
 # during compilation, packaging, distribution, etc.
 #
-version: 3.0.1
+version: 3.0.2
 apiversion: 2
 architectures: armv7 arm64 i386 x86_64
 description: titanium-web-dialog