SignedCapsulePkg: Allow hex FirmwareType values in ini files #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ajfish,
leiflindholm and
mdkinney
Some platforms such as Ampere Altra have special values for the FirmwareType field: for example 2147483649 is for SCP updates. To make such values easier to read/understand, allow them to be written in hex: in this case it would be 0x80000001. Implement this by attempting to get a hex integer from the ini data file if reading a decimal value fails. Signed-off-by: Rebecca Cran <[email protected]>
bexcran
force-pushed
the
allow-hex-firmwaretype-capsule-updates
branch
from
8824e96
to
4c2fff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some platforms such as Ampere Altra have special values for the FirmwareType field: for example 2147483649 is for SCP updates.
To make such values easier to read/understand, allow them to be written in hex: in this case it would be 0x80000001. Implement this by attempting to get a hex integer from the ini data file if reading a decimal value fails.
How This Was Tested
Write a SystemFirmwareUpdateConfig.ini file with a FirmwareType value of 0x80000002 and verified it was correctly read and interpreted when applying a capsule update.
Integration Instructions
N/A