Feature/add db dir config and refactor #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help eliminate ActiveRecord creating an extra, erroneous directory when a custom path is specified. Moved the defaults data, as a constant, to a method, to help minimize another. Using ruby Hash access method to make config loading code more readable, and taking care not to overwrite defaults when new options have key, but only nil values. Removed parameter to use class access strategy instead.
at least internally to make each change more obviously connected, separating the naming from the arbitrary override configuration names and organization. Made dynamically producing the name of that file more readable as a single line, string interpolation statement. Removing schema from main config object as that does not get applied to the Rails config object later like other related settings. Cleaning other redundant/extra code since using instance variables anyway.
to help eliminate error when working on several parts of the software; possible future configuration override additions require edits to less sections now; it is more automated. Continuing the use of convenient variable short-name pattern. Updating string literal syntax to only use double quotes when special handling is necessary.
per readme guidance.
Add generic error check test case. Make sure defaults are still being applied when configuration file does not exist. Move defaults section high in order of increasing dependency usage and complexity. Convert to checking entire, internal configuration and its members, along with the Rails configuration-matching path style. Add test cases for new 'db dir' property. Organize whitespace and other content in file within a narrow, more readable horizontal boundary, and align common data values in a similar, table format. Added to gitignore file where I had lingering files after running a broader `rspec` command, and also seems to never complete. `bundle exec rake spec` does not have this problem, and must be more specifically configured not to. Also added proper, and careful, handling for the init options, since there is no deep_merge.., without all of Rails?
thuss
approved these changes
Nov 17, 2023
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #181.
Version advance to 7.2 with this new feature?
That's by semver, but if you're still matching Rails version numbers, then 7.1.3 then?